Skip to content

Allow displaying multiple results #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 17, 2022
Merged

Allow displaying multiple results #21

merged 5 commits into from
Feb 17, 2022

Conversation

scsmithr
Copy link
Contributor

@scsmithr scsmithr commented Feb 17, 2022 •
edited
Loading

Fixes #19

image

I've only tested this with postgres. Still need to make sure the changes still work with mysql and mssql.

@scsmithr
Copy link
Contributor Author

Added a "Multiple statements" option for mysql connections to allow for multiple statements in a single cell.

I did not test mssql because it's kind of a pain to spin up locally. But the changes I made should keep it working as is:tm:.

@scsmithr scsmithr marked this pull request as ready for review February 17, 2022 20:03
cmoog
cmoog approved these changes Feb 17, 2022
View reviewed changes
Copy link
Owner

@cmoog cmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. The mysql configuration addition is a nice improvement.

Squashing and merging 🚢

@cmoog cmoog merged commit 454d86a into cmoog:master Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmoog cmoog cmoog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple SQL statements in a single cell causes execution to never complete
2 participants
@scsmithr @cmoog